Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): dont use rem sizes on width and height properties #1708

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

joshuaellis
Copy link
Member

@joshuaellis joshuaellis commented Apr 29, 2024

What does it do?

  • icons by default at 16 as a number not in rem.

Related issue(s)/PR(s)

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: icons relates to icons package labels Apr 29, 2024
@joshuaellis joshuaellis self-assigned this Apr 29, 2024
Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 5d92d1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/icons Patch
@strapi/ui-primitives Patch
@strapi/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:40pm
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:40pm
design-system-website ❌ Failed (Inspect) Apr 29, 2024 2:40pm

Copy link

github-actions bot commented Apr 29, 2024

Size Change: -299 B (0%)

Total Size: 486 kB

Filename Size Change
packages/strapi-icons/dist/index.js 22.1 kB -37 B (0%)
packages/strapi-icons/dist/index.mjs 21.7 kB -22 B (0%)
packages/strapi-icons/dist/symbols-index.js 11.9 kB -140 B (-1%)
packages/strapi-icons/dist/symbols-index.mjs 11.8 kB -100 B (-1%)
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB
packages/strapi-design-system/dist/index.js 194 kB
packages/strapi-design-system/dist/index.mjs 192 kB

compressed-size-action

@joshuaellis joshuaellis merged commit b9646de into releases/2.0.0 Apr 29, 2024
7 of 8 checks passed
@joshuaellis joshuaellis deleted the fix/icons-should-use-px-not-rem branch April 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: icons relates to icons package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: 2.0.0-beta.2 - invalid value for <svg> attribute width="1.6rem"
2 participants