Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: remove size from inputs #1718

Merged
merged 3 commits into from
May 8, 2024
Merged

chore!: remove size from inputs #1718

merged 3 commits into from
May 8, 2024

Conversation

joshuaellis
Copy link
Member

chore!: remove size from inputs

What does it do?

  • removes size from inputs and uses padding instead

Why is it needed?

  • we don't use size, it's a maintenance burden and really, we should be using padding's anyway so it works with RTL

Related issue(s)/PR(s)

  • resolves DX-1296

@joshuaellis joshuaellis added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package labels May 7, 2024
@joshuaellis joshuaellis self-assigned this May 7, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024 •
edited

🦋 Changeset detected

Latest commit: 44463ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:47am
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 8:47am
design-system-website ❌ Failed (Inspect) May 8, 2024 8:47am

@joshuaellis joshuaellis force-pushed the chore/refactor-size-to-be-variant branch from 3fa223f to b1a71fc Compare May 7, 2024 20:03
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

Size Change: -797 B (0%)

Total Size: 292 kB

Filename Size Change
packages/design-system/dist/index.js 96.6 kB -407 B (0%)
packages/design-system/dist/index.mjs 95.3 kB -390 B (0%)
ℹ️ View Unchanged
Filename Size
packages/icons/dist/index.js 22.1 kB
packages/icons/dist/index.mjs 21.7 kB
packages/icons/dist/symbols-index.js 11.9 kB
packages/icons/dist/symbols-index.mjs 11.8 kB
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB

compressed-size-action

@joshuaellis joshuaellis changed the title chore: remove size from inputs chore!: remove size from inputs May 7, 2024
innerdvations
innerdvations reviewed May 8, 2024
View reviewed changes
packages/design-system/src/components/Badge/Badge.tsx Outdated
`;

export type BadgeSize = 'S' | 'M';
type BadgeSizes = 'S' | 'M';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For types, singular makes more sense to me. If size: BadgeSize I know it's a badge size. If I see size: BadgeSizes I expect I can pass in an array of sizes or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think? I was super on the fence about this, and i don't really mind – I wanted to find a library that did something i could draw upon, if you feel strongly about it im happy to do it 😄

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so, although I feel bad that we've had that "deprecated: use BadgeSizes" and now we're undeprecating it (once you remove the comment) instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the deprecation here, so dw lol

packages/design-system/src/components/Accordion/Accordion.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/Combobox/Combobox.tsx Outdated Show resolved Hide resolved
packages/design-system/src/components/IconButton/IconButton.tsx Outdated Show resolved Hide resolved
@joshuaellis joshuaellis force-pushed the chore/refactor-size-to-be-variant branch from 7a4eeca to f81f78d Compare May 8, 2024 08:28
@joshuaellis joshuaellis force-pushed the chore/refactor-size-to-be-variant branch 2 times, most recently from 552f613 to 749f14e Compare May 8, 2024 08:30
@joshuaellis joshuaellis force-pushed the chore/refactor-size-to-be-variant branch from 749f14e to f2fcebc Compare May 8, 2024 08:37
@joshuaellis joshuaellis merged commit 981d6d0 into releases/2.0.0 May 8, 2024
11 of 12 checks passed
@joshuaellis joshuaellis deleted the chore/refactor-size-to-be-variant branch May 8, 2024 08:47
@github-actions github-actions bot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@Bassel17 Bassel17 Awaiting requested review from Bassel17

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

Assignees

@joshuaellis joshuaellis

Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: design-system relates to design-system package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaellis @innerdvations