Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: refactor Tooltip to use radix-ui #1722

Merged
merged 3 commits into from
May 10, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • refactors Tooltip to use radix-ui
  • refactors IconButton API to only use children & label for a cohesive API across the rest of the components & adds withTooltip prop to control in-built tooltip availability

Why is it needed?

  • less code to maintain ✅

Related issue(s)/PR(s)

  • resolves DX-1212

@joshuaellis joshuaellis added pr: feature This PR adds a new feature source: design-system relates to design-system package labels May 9, 2024
@joshuaellis joshuaellis self-assigned this May 9, 2024
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:20am
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 7:20am
design-system-website ❌ Failed (Inspect) May 10, 2024 7:20am

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: ca60e28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 9, 2024

Size Change: -1.46 kB (-0.51%)

Total Size: 287 kB

Filename Size Change
packages/design-system/dist/index.js 94.1 kB -752 B (-0.79%)
packages/design-system/dist/index.mjs 92.9 kB -711 B (-0.76%)
ℹ️ View Unchanged
Filename Size
packages/icons/dist/index.js 22.1 kB
packages/icons/dist/index.mjs 21.7 kB
packages/icons/dist/symbols-index.js 11.9 kB
packages/icons/dist/symbols-index.mjs 11.8 kB
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB

compressed-size-action

Copy link

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't QA it but code LGTM

packages/design-system/src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: feature This PR adds a new feature source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants