Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completing the steps for populating fields for API #1508

Closed
wants to merge 2 commits into from

Conversation

arkni8
Copy link

@arkni8 arkni8 commented Feb 15, 2023

What does it do?

The documentation for populatingCreatorFields was incomplete. The steps mentioned currently is incomplete and seems to apply for strapiV3, it seems. As this comment under the closed issue #12228 points out, the documentation needs to be updated to reflect the new steps. But it never happened so I added a few more steps to complete the documentation in order to have the populateCreatorField fully working in strapiV4.

Why is it needed?

The documentation was incomplete and made newcomers waste time searching through github and forum for answer, like I had to as well. Which is why I felt the need to update the steps to make the documentation inline with strapiV4's expected behavior.

Related issue(s)/PR(s)

Issue #12228 discusses the same.

Let us know if this is related to any issue/pull request

@strapi-cla
Copy link

strapi-cla commented Feb 15, 2023

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
documentation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 4:20PM (UTC)
documentation-docu-mvp ❌ Failed (Inspect) Feb 15, 2023 at 4:20PM (UTC)

@stb13579
Copy link
Contributor

Hello @arkni8. Thanks for opening this PR. We have frozen community contributions for the next week while we transition to a new documentation tool. I will try to check and review your PR as soon as we are able to handle community contributions again. For more information please see the following issue: #1507

@stb13579 stb13579 self-assigned this Feb 15, 2023
@arkni8
Copy link
Author

arkni8 commented Feb 15, 2023

@StrapiShaun Ahh, Okay thanks Shaun. I did see the Issue post but I don't know why I thought it today is Feb 25. Haha.

Please check whenever you feel is right thanks again!

@pwizla
Copy link
Collaborator

pwizla commented Feb 22, 2023

Hi @arkni8. Thanks again for your contribution. We've had a major update to our documentation code base today. I'm setting up the target branch to backup/main as it'll be easier to review changes. Once reviewed, I'll replicate this in the new main branch.

@pwizla pwizla changed the base branch from main to backup/main February 22, 2023 22:32
pwizla added a commit that referenced this pull request Mar 6, 2023
@pwizla pwizla mentioned this pull request Mar 6, 2023
@pwizla
Copy link
Collaborator

pwizla commented Mar 6, 2023

Thank you again, @arkni8! We appreciate your contribution. I've ported these changes to our new documentation (see #1565) and will close this PR targeting the older repository content.

@pwizla pwizla closed this Mar 6, 2023
pwizla added a commit that referenced this pull request Mar 6, 2023
@arkni8
Copy link
Author

arkni8 commented Mar 6, 2023

Nice, thanks for all the good work. Cheers!

pwizla added a commit that referenced this pull request Mar 6, 2023
* Fix Entreprise badge spelling

* Add Hotjar script to Docusaurus (#1562)

* Rename EntrepriseBadge to EnterpriseBadge (#1563)

* Port #1508 to Docusaurus (#1565)

* Update 'code' font size behavior

* Fix U&P right sidebar and add ids (#1567)

---------

Co-authored-by: Udi Silvestre <udi.silvestre@strapi.io>
Co-authored-by: Udi Silvestre <4141420+udimberto@users.noreply.github.com>
pwizla added a commit that referenced this pull request Mar 6, 2023
* Fix Entreprise badge spelling

* Add Hotjar script to Docusaurus (#1562)

* Rename EntrepriseBadge to EnterpriseBadge (#1563)

* Port #1508 to Docusaurus (#1565)

* Update 'code' font size behavior

* Fix U&P right sidebar and add ids (#1567)

* Add DEITS keyword to data management system

---------

Co-authored-by: Udi Silvestre <udi.silvestre@strapi.io>
Co-authored-by: Udi Silvestre <4141420+udimberto@users.noreply.github.com>
pwizla added a commit that referenced this pull request Mar 7, 2023
* Fix Entreprise badge spelling

* Add Hotjar script to Docusaurus (#1562)

* Rename EntrepriseBadge to EnterpriseBadge (#1563)

* Port #1508 to Docusaurus (#1565)

* Update 'code' font size behavior

* Fix U&P right sidebar and add ids (#1567)

* Add DEITS keyword to data management system

* Update table-of-contents icons style (#1573)

---------

Co-authored-by: Udi Silvestre <udi.silvestre@strapi.io>
Co-authored-by: Udi Silvestre <4141420+udimberto@users.noreply.github.com>
pwizla added a commit that referenced this pull request Mar 7, 2023
* Fix Entreprise badge spelling

* Add Hotjar script to Docusaurus (#1562)

* Rename EntrepriseBadge to EnterpriseBadge (#1563)

* Port #1508 to Docusaurus (#1565)

* Update 'code' font size behavior

* Fix U&P right sidebar and add ids (#1567)

* Add DEITS keyword to data management system

* Update table-of-contents icons style (#1573)

* Remove outdated public middleware docs, update admin redirect (#1571)

* Remove outdated public middleware docs, update admin redirect

* Use codeblock title instead of manually indicating the path

---------

Co-authored-by: Udi Silvestre <udi.silvestre@strapi.io>
Co-authored-by: Udi Silvestre <4141420+udimberto@users.noreply.github.com>
Co-authored-by: Andrew Luca <1881266+iamandrewluca@users.noreply.github.com>
pwizla added a commit that referenced this pull request Mar 7, 2023
* Fix Entreprise badge spelling

* Add Hotjar script to Docusaurus (#1562)

* Rename EntrepriseBadge to EnterpriseBadge (#1563)

* Port #1508 to Docusaurus (#1565)

* Update 'code' font size behavior

* Fix U&P right sidebar and add ids (#1567)

* Add DEITS keyword to data management system

* Update table-of-contents icons style (#1573)

* Remove outdated public middleware docs, update admin redirect (#1571)

* Remove outdated public middleware docs, update admin redirect

* Use codeblock title instead of manually indicating the path

* Remove outdated FAQs and update some content of others (#1578)

---------

Co-authored-by: Udi Silvestre <udi.silvestre@strapi.io>
Co-authored-by: Udi Silvestre <4141420+udimberto@users.noreply.github.com>
Co-authored-by: Andrew Luca <1881266+iamandrewluca@users.noreply.github.com>
Co-authored-by: DMehaffy <derrickmehaffy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants