Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #47: Implement Mobile Menu in Navbar Component #62

Merged
merged 1 commit into from Aug 2, 2023
Merged

Issue #47: Implement Mobile Menu in Navbar Component #62

merged 1 commit into from Aug 2, 2023

Conversation

AnasGamal
Copy link
Contributor

@AnasGamal AnasGamal commented Jul 4, 2023 •
edited

Issue #47: Mobile menu not implemented in navbar component

Fix:

  • Added mobileMenuOpen state variable and closeMenu function.
  • Created MobileNavLink component for mobile menu navigation links.
  • Implemented Dialog component from @headlessui/react for the mobile menu.
  • Added a button with Bars3Icon to toggle the mobile menu.
  • Added @headlessui/react and @heroicons/react as dependencies.

Screenshots:
homepageView
mobileMenuView

@AnasGamal AnasGamal mentioned this pull request Jul 4, 2023
Closed
PaulBratslavsky
PaulBratslavsky approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@PaulBratslavsky PaulBratslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep saying you are the best a lot. Lol. Thank you for this update.

@PaulBratslavsky PaulBratslavsky merged commit 134a18d into strapi:main Aug 2, 2023
@PaulBratslavsky
Copy link
Contributor

@AnasGamal I keep saying you are the best a lot. Lol. Thank you for this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulBratslavsky PaulBratslavsky PaulBratslavsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnasGamal @PaulBratslavsky