fix: generate plugins that work for v5 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea7059a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Ben Irvin <ben@innerdvations.com>
…into fix/build-error
joshuaellis
reviewed
May 20, 2024
joshuaellis
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
export * as X from 'X'syntax instead ofimport X from 'X'; export default { X }to correctly preserve inferred typesWhy is it needed?
Plugins were still broken for v5
How to test it?
There is one missing piece to get it to build, which is the tsconfig: strapi/strapi#20341
But if you generate a plugin and then manually add that to the tsconfig yourself, it should now build with no errors.
Related issue(s)/PR(s)
strapi/strapi#20341
DX-1400