Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GitHub actions for docker builds #319

Conversation

ChristianHeimke
Copy link

about / background

This PR enables Github action to build all released strapi versions as docker image and push it to the docker hub. It will skip the build process if a tag already exists.
It is more "docker-like" and make the build process more transparent for others.

usage

The workflow will run every night automatically, pull the current strapi releases from Github and grab the current image tags from dockerhub. It will generate a build matrix based on the strapi versions, nodejs versions (basic and alpine) to build and the flavour of the image (base or strapi). The build process will be skipped if the image tag already exists or contains the keyword beta (needs to be skipped because yarn can't find the beta package).

demo images

you can find the testing builds here: https://hub.docker.com/r/loumaris/strapi/tags

todo

If you accept the PR some small updates are needed:

  • docker hub path needs to be changed to strapi/strapi
  • add docker credentials as secrets for pushing the image
  • update github/docker repository to a community driven project to increase the limits
  • update/change badges in README.md
  • maybe skip / remove older tags

@strapi-cla
Copy link

strapi-cla commented Oct 10, 2021

CLA assistant check
All committers have signed the CLA.

strategy:
matrix:
strapi: ["base", "strapi"]
node: ["12", "12-alpine", "14", "14-alpine"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about node 16? As i know, Strapi v4 works on node v16.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest set node-14 and 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants