replace login-react app #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Noël <petersg83@gmail.com>
soupette
suggested changes
Jul 27, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
Signed-off-by: Pierre Noël <petersg83@gmail.com>
soupette
suggested changes
Jul 27, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
soupette
suggested changes
Jul 28, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
petersg83
force-pushed
the
replaceLoginApp
branch
from
0e83406
to
7b19082
Compare
soupette
suggested changes
Jul 28, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
|
So before I review the code, was trying to talk a user through this, I think it would be helpful to make a Miro flow diagram to roughly go over the redirect process from start to finish (from the initial /connect/:provider to the final JWT response). |
derrickmehaffy
requested changes
Aug 7, 2020
login-react/README.md
Outdated
|
|
||
| **14 -** [Enable VK provider](./doc/vk_setup.md) | ||
| **4 —** Configure one or several providers by following the instructions there: https://strapi.io/documentation/v3.x/plugins/users-permissions.html#providers |
There was a problem hiding this comment.
... follow the instructions here:
|
|
||
| useEffect(() => { | ||
| // Successfully logged with the provider | ||
| // Now logging with strapi by using the access_token in props.location.search |
There was a problem hiding this comment.
Make a note this access_token comes from the provider (we want it to be as clear as possible)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged along with strapi/strapi#7132