Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button of repeatable components is missing a focus outline and focus handling #15109

Closed
gu-stav opened this issue Dec 7, 2022 · 2 comments
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Dec 7, 2022

Bug report

Required System information

  • Node.js version: not applicable
  • NPM version: not applicable
  • Strapi version: 4.5.3
  • Database: not applicable
  • Operating system: MacOS

Describe the bug

The "Add item" button of repeatable components has two a11y issues:

  • focus outline is missing
  • after item creation, the focus is not set on the item being created
Kapture.2022-12-07.at.12.15.08.mp4

Steps to reproduce the behavior

  1. Create a content-type with a repeatable component
  2. Tab to "Create item"
  3. Hit enter

Expected behavior

I expect a focus indicator to be visible. I expect the focus to be handled properly (on the created item?).

@gu-stav gu-stav added issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around status: confirmed Confirmed by a Strapi Team member or multiple community members source: core:content-manager Source is core/content-manager package labels Dec 7, 2022
@gu-stav gu-stav changed the title Add button of repeatable components is missing a focus outline and focus handline Add button of repeatable components is missing a focus outline and focus handling Dec 7, 2022
@BhuvaneshPatil
Copy link

BhuvaneshPatil commented Dec 9, 2022

Hello @gu-stav ,
I have investigated this issue. The problems I have found are the following and how they can be tackled.

  • The Add an Entry buttons is being focussed, but the styling ( outlines/borders ) is not visible. The reason behind this behavior is, the child is completely fitting the parent ( which is flex ).

Here is the screenshot of the code -

Flex and Button Code

The good fix for this is to apply some padding to the parent.

image

For focussing on the input when we add input is I am exploring right now.

@gu-stav
Copy link
Contributor Author

gu-stav commented Dec 22, 2022

Fixed by the attached PR.

@gu-stav gu-stav closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:content-manager Source is core/content-manager package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
Status: Fixed/Shipped
Archived in project
Development

No branches or pull requests

2 participants