Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaging the favicon does not work #19238

Open
DenuxPlays opened this issue Jan 17, 2024 · 4 comments
Open

Chaging the favicon does not work #19238

DenuxPlays opened this issue Jan 17, 2024 · 4 comments
Assignees
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:admin Source is core/admin package status: pending reproduction Waiting for free time to reproduce the issue, or more information

Comments

@DenuxPlays
Copy link

Bug report

Required System information

  • Node.js version: 18.18.2
  • NPM version: 9.8.1
  • Strapi version: 4.15.5
  • Database: MariaDB 10.6
  • Operating system: Debian 12.4
  • Is your project Javascript or Typescript: Typescript

Describe the bug

This is the config we export via the admin.tsx file:

import favicon from "./extensions/favicon.png";
import logo from "./extensions/logo.svg";

export default {
  config: {
    head: {
      favicon: favicon,
    },
    menu: {
      logo: logo,
    },
    auth: {
      logo: logo,
    },
}

Both the menu and auth logo are getting replaced but the favicon stays the same.
Checked the browser cache etc. the favicon isn't cached.

Steps to reproduce the behavior

  1. Go to your admin.js|.ts file
  2. update the file with the same content
  3. Open strapi, see the favicon not changing

Expected behavior

The favicon should be the one I provide.

Screenshots

/

Code snippets

import favicon from "./extensions/favicon.png";
import logo from "./extensions/logo.svg";

export default {
  config: {
    head: {
      favicon: favicon,
    },
    menu: {
      logo: logo,
    },
    auth: {
      logo: logo,
    },
}

Additional context

/

@zlaazlaa
Copy link

You can try to change the origin favicon.png file in the root of strapi project. @DenuxPlays

@DenuxPlays
Copy link
Author

You can try to change the origin favicon.png file in the root of strapi project. @DenuxPlays

Yeah that worked.
Please mention something like this in the wiki.

@zlaazlaa
Copy link

You can try to change the origin favicon.png file in the root of strapi project. @DenuxPlays

Yeah that worked. Please mention something like this in the wiki.

@DenuxPlays Great to hear that it worked for you! I've taken note of your suggestion and updated the wiki to include information about changing the origin favicon.png file in the root of the Strapi project. You can check out the changes in my pull request here: strapi/documentation#1983. Thanks for bringing this to my attention!

@DenuxPlays
Copy link
Author

You can try to change the origin favicon.png file in the root of strapi project. @DenuxPlays

Yeah that worked. Please mention something like this in the wiki.

@DenuxPlays Great to hear that it worked for you! I've taken note of your suggestion and updated the wiki to include information about changing the origin favicon.png file in the root of the Strapi project. You can check out the changes in my pull request here: strapi/documentation#1983. Thanks for bringing this to my attention!

Thank you for updating the documentation so fast.
Looks good!

@joshuaellis joshuaellis added issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:admin Source is core/admin package status: pending reproduction Waiting for free time to reproduce the issue, or more information labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug severity: low If the issue only affects a very niche base of users and an easily implemented workaround can solve source: core:admin Source is core/admin package status: pending reproduction Waiting for free time to reproduce the issue, or more information
Projects
Status: To be reviewed (Open)
Status: To review
Development

No branches or pull requests

4 participants