Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout in loadHooks needs to be configurable. #63

Closed
stefan1968 opened this issue Jan 13, 2016 · 2 comments
Closed

Timeout in loadHooks needs to be configurable. #63

stefan1968 opened this issue Jan 13, 2016 · 2 comments
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature
Milestone

Comments

@stefan1968
Copy link

function loadHook(id, cb) {
  const timeoutInterval = 5000;
  let hookTimeout;
  ...
}

in File : https://github.com/wistityhq/strapi/blob/master/lib/private/loadHooks.js#L85

We need a way of setting the timeout via the strapi environment. This value is too small for remote connections, for example Amazon RDS.

@loicsaintroch loicsaintroch added this to the v2.0.0 milestone Jan 13, 2016
@loicsaintroch loicsaintroch added issue: enhancement Issue suggesting an enhancement to an existing feature framework labels Jan 13, 2016
@loicsaintroch
Copy link

I'll take a look at it this afternoon @stefan1968.

@loicsaintroch loicsaintroch modified the milestones: v1.5.0, v2.0.0 Jan 19, 2016
@loicsaintroch
Copy link

Just released the v1.5.4 without a hook timeout. We decided to remove it since it depends on the environment and we can't control it. Also, it's useless. This is the best option we have.

@strapi strapi locked and limited conversation to collaborators Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants