Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insertion of certain field names lead to database crash "on" #6614

Closed
bevenio opened this issue Jun 10, 2020 · 3 comments 路 Fixed by #7036
Closed

Insertion of certain field names lead to database crash "on" #6614

bevenio opened this issue Jun 10, 2020 · 3 comments 路 Fixed by #7036
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:strapi Source is core/strapi package status: confirmed Confirmed by a Strapi Team member or multiple community members

Comments

@bevenio
Copy link

bevenio commented Jun 10, 2020

Hi 馃憢

Describe the bug
The strapi admin UI allows the insertion of field names inside the content type builder that lead to a database crash (mongoDB)

Steps to reproduce the behavior

  1. Open the strapi admin UI
  2. Create a new content type with a field called "on" with "Boolean" as the type
  3. Save the content type

Expected behavior
Blacklisting certain field names that will lead to database errors

System

  • Node.js version: v12.13.0
  • Strapi version: 3.0.1
  • Database: MongoDB
  • Operating system: Centos 8

Additional context
To fix the issue I had to remove the JSON-File from the created model template (*.settings.json)
@derrickmehaffy
Copy link
Member

hmmm @soupette @alexandrebodin looks like we need to update the "not-allowed" list lol

@lauriejim lauriejim changed the title Insertion of certain field names lead to database crash Insertion of certain field names lead to database crash "on" Jun 16, 2020
@lauriejim lauriejim added severity: medium If it breaks the basic use of the product but can be worked around source: core:strapi Source is core/strapi package status: confirmed Confirmed by a Strapi Team member or multiple community members issue: bug Issue reporting a bug labels Jun 16, 2020
@soupette
Copy link
Contributor

@derrickmehaffy that list is going to be endless 馃槀!

@Convly or @petersg83 can you check?

@derrickmehaffy
Copy link
Member

@derrickmehaffy that list is going to be endless 馃槀!

@Convly or @petersg83 can you check?

Yes.... Yes it will until we find a different way to deal with the "names"

@petersg83 petersg83 mentioned this issue Jul 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around source: core:strapi Source is core/strapi package status: confirmed Confirmed by a Strapi Team member or multiple community members
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add more reserved words to the list strapi/strapi
4 participants
@lauriejim @derrickmehaffy @soupette @bevenio