Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows build #502

Closed
wants to merge 1 commit into from
Closed

Fix Windows build #502

wants to merge 1 commit into from

Conversation

nachovizzo
Copy link

And other probably too... since the original change (introduced in #376) does not work.

As an example :

#define SOPHUS_FMT_ARG(arg)

#else  // !SOPHUS_USE_BASIC_LOGGING

But later is fixed, thus, only works when using fmt:

#if FMT_VERSION >= 90000
#define SOPHUS_FMT_ARG(arg) fmt::streamed(arg)
#else
#define SOPHUS_FMT_ARG(arg) arg
#endif

This PR fixes #394 and #436

@nachovizzo
Fix Windows build
05e81db 
And other probably too
This was referenced Mar 26, 2023
Closed
Merged
nachovizzo added a commit to PRBonn/kiss-icp that referenced this pull request Mar 26, 2023
@nachovizzo
Fix Sophus Windows build.
a1d7fa9 
In the meantime while strasdat/Sophus#502 gets
through
@nachovizzo
Copy link
Author

Closing this due to lack of activity :) feel free to reopen if needed

@nachovizzo nachovizzo closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax Error with VS2019 in several headers
1 participant
@nachovizzo