You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Below is the patch I applied (sorry for inlining it since it's just one line and I have not forked the project). In short, we can't assign using quaternion() since it's const. I've just changed it to quaternion_nonconst().
I thought I had unit test coverage for this but this bug is more subtle than it seems. In particular, this assignment-like operator is almost never called, since the default assignment operator was still generated by the compiler.
Below is the patch I applied (sorry for inlining it since it's just one line and I have not forked the project). In short, we can't assign using
quaternion()
since it's const. I've just changed it toquaternion_nonconst()
.The text was updated successfully, but these errors were encountered: