Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loopdev 0.4.0 failing to build from source #607

Closed
mulkieran opened this issue Apr 17, 2023 · 6 comments
Closed

loopdev 0.4.0 failing to build from source #607

mulkieran opened this issue Apr 17, 2023 · 6 comments
Assignees
@mulkieran
Projects
2024January

Comments

@mulkieran
Copy link
Member

See #589 for further investigation
@mulkieran mulkieran self-assigned this Apr 17, 2023
@mulkieran mulkieran added this to To do in 2023April via automation Apr 17, 2023
@mulkieran mulkieran mentioned this issue Apr 17, 2023
Merged
mulkieran added a commit to mulkieran/ci that referenced this issue Apr 17, 2023
@mulkieran
Do not compile tests when vendoring
11615a7 
Test may fail to compile due to loopdev crate FTBFS.
See stratis-storage/project#607

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran mentioned this issue Apr 17, 2023
Merged
@mulkieran
Copy link
Member Author

We can not rule out the possibility that the failure is somewhat toolchain version dependent, so that the bug may only evidence on newer Rust toolchain versions (because the newest version of proc_macros2 is probably not tested with older Rust toolchain versions).

mulkieran added a commit to mulkieran/ci that referenced this issue Apr 17, 2023
@mulkieran
Do not compile tests when vendoring
b10312e 
Test may fail to compile due to loopdev crate FTBFS.
See stratis-storage/project#607

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran mulkieran moved this from To do to In progress (long term) in 2023April Apr 17, 2023
mulkieran added a commit to mulkieran/ci that referenced this issue Apr 17, 2023
@mulkieran
Do not compile tests when vendoring
6cdfbf2 
Test may fail to compile due to loopdev crate FTBFS.
See stratis-storage/project#607

Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran added a commit to mulkieran/ci that referenced this issue Apr 18, 2023
@mulkieran
Do not compile tests when vendoring
f989a43 
Test may fail to compile due to loopdev crate FTBFS.
See stratis-storage/project#607

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

It looks like we'll be getting a new upstream release in a week or so.

@mulkieran mulkieran moved this from In progress (long term) to Pending in 2023April Apr 19, 2023
This was referenced Apr 23, 2023
Merged
Merged
@mulkieran mulkieran added this to To do in 2023May via automation May 1, 2023
@mulkieran mulkieran removed this from Pending in 2023April May 1, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023May May 1, 2023
@mulkieran
Copy link
Member Author

mulkieran commented May 1, 2023 •
edited

We can improve the situation slightly by updating Cargo.toml patch table entries to point to specific branch and commit of loopdev repo, instead of my personal branch. This would not quite work, due to the version bump. So all we would really get is a patch to an improved mulkieran branch. So it is probably not worth the trouble.

@mulkieran mulkieran moved this from Pending to In progress in 2023May May 1, 2023
@mulkieran mulkieran moved this from In progress to Pending in 2023May May 1, 2023
@mulkieran mulkieran removed this from Pending in 2023May Jun 5, 2023
@mulkieran mulkieran added this to To do in 2023June via automation Jun 5, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023June Jun 5, 2023
@mulkieran mulkieran removed this from Pending in 2023June Jul 10, 2023
@mulkieran mulkieran added this to To do in 2023July via automation Jul 10, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023July Jul 10, 2023
@mulkieran mulkieran removed this from Pending in 2023July Aug 7, 2023
@mulkieran mulkieran added this to To do in 2023August via automation Aug 7, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023August Aug 7, 2023
@mulkieran mulkieran moved this from Pending to In progress (long term) in 2023August Aug 16, 2023
@mulkieran mulkieran moved this from In progress (long term) to Pending in 2023August Aug 16, 2023
@mulkieran mulkieran removed this from Pending in 2023August Sep 5, 2023
@mulkieran mulkieran added this to To do in 2023September via automation Sep 5, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023September Sep 5, 2023
@mulkieran mulkieran added this to To do in 2023October via automation Sep 29, 2023
@mulkieran mulkieran removed this from Pending in 2023September Sep 29, 2023
@mulkieran mulkieran moved this from To do to Pending in 2023October Sep 29, 2023
@mulkieran
Copy link
Member Author

Seems like loopdev's problems may be permanent.

@mulkieran mulkieran removed this from Pending in 2023October Oct 30, 2023
@mulkieran mulkieran added this to misc in tracking Oct 30, 2023
@mulkieran mulkieran mentioned this issue Nov 13, 2023
Merged
@mulkieran mulkieran removed this from misc in tracking Nov 13, 2023
@mulkieran mulkieran added this to To do in 2023November via automation Nov 13, 2023
This was referenced Nov 13, 2023
Merged
Closed
@mulkieran
Copy link
Member Author

If we decide that this is the correct way to go, we will start the packaging process in Fedora.

This was referenced Nov 13, 2023
Closed
Open
@mulkieran mulkieran moved this from To do to In progress (long term) in 2023November Nov 13, 2023
@mulkieran mulkieran removed this from In progress (long term) in 2023November Dec 4, 2023
@mulkieran mulkieran added this to To do in 2023December via automation Dec 4, 2023
@mulkieran mulkieran moved this from To do to In progress (long term) in 2023December Dec 4, 2023
@mulkieran mulkieran removed this from In progress (long term) in 2023December Jan 2, 2024
@mulkieran mulkieran added this to To do in 2024January via automation Jan 2, 2024
@mulkieran mulkieran moved this from To do to In progress (long term) in 2024January Jan 2, 2024
@mulkieran
Copy link
Member Author

Closed in favor of #677

2024January automation moved this from In progress (long term) to Done Jan 11, 2024
@mulkieran mulkieran mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
No open projects
2024January
Done (2)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mulkieran