Changes to dbus api methods #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mulhern <amulhern@redhat.com>
It's a bit easier to debug, but I think it is also generally slightly better. Signed-off-by: mulhern <amulhern@redhat.com>
|
This is not ready yet, I will see if the similar can be done with the append calls. |
Also, be less verbose w/ signature information. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
|
@agrover review? It looks like the append*() methods, if used to their fullest extent, would be full of surprises, so I'm just going to rest on this. The last three commits are therefore just bug fixes and minor fixups. |
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Jul 7, 2017
Document align_to() method
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
May 23, 2019
Resolves: stratis-storage#76 Signed-off-by: mulhern <amulhern@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the recommended approach for extracting data from message.
Distinguishes between missing args and invalid types of args.
If invalid type of arg, gives the index of the argument, not its actual value, which I think is just as good.
Also, swaps the order of devs and raidtype in create_pool.