Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master failure #988

Closed
wants to merge 1 commit into from
Closed

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Jun 13, 2018

Related: #530.
Related: #776.
Related: #766.

@mulkieran mulkieran self-assigned this Jun 13, 2018
@mulkieran mulkieran added this to To do in Stratis 1.0 (Sprint 9) via automation Jun 13, 2018
@mulkieran mulkieran moved this from To do to In progress in Stratis 1.0 (Sprint 9) Jun 13, 2018
@mulkieran mulkieran force-pushed the master-failure branch 4 times, most recently from faa7842 to a3eb0e9 Compare June 14, 2018 13:47
@mulkieran
Copy link
Member Author

Very wierd Jenkins failure: https://stratis-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/stratisd/1375/.

Error where actual blockdev size is 1/10 the size of the recorded block dev size. I'm going to restart Jenkins and see what happens.
However, this is a definite place where error reporting could be better. If we got the blockdev size, we had a handle on the blockdev itself, for example, its devnode, and this could have been included.

@mulkieran
Copy link
Member Author

Blocked by #1004.

@mulkieran mulkieran moved this from In Review to Blocked in Stratis 1.0 (Sprint 9) Jul 2, 2018
@mulkieran mulkieran moved this from Blocked to In Review in Stratis 1.0 (Sprint 9) Jul 2, 2018
@mulkieran
Copy link
Member Author

No longer blocked.

@mulkieran
Copy link
Member Author

It's been a month and no feedback, so I'm moving it back to in-progress and seeing what more I can do w/ it.

@mulkieran mulkieran moved this from In Review to In progress in Stratis 1.0 (Sprint 9) Jul 13, 2018
@agrover agrover moved this from In progress to Blocked in Stratis 1.0 (Sprint 9) Jul 17, 2018
@agrover agrover added this to the Stratis 2.0 milestone Aug 21, 2018
@agrover agrover removed this from Blocked in Stratis 1.0 (Sprint 9) Aug 21, 2018
@mulkieran mulkieran force-pushed the master-failure branch 2 times, most recently from 5a30179 to 41f159a Compare November 26, 2018 19:49
@mulkieran
Copy link
Member Author

rebased.

@mulkieran mulkieran force-pushed the master-failure branch 3 times, most recently from 1c8a0ce to f6ffc91 Compare November 26, 2018 20:57
@mulkieran mulkieran removed this from the Stratis 2.0 milestone Nov 27, 2018
@mulkieran mulkieran added this to In Progress in Stratis 1.1 via automation Nov 27, 2018
@mulkieran
Copy link
Member Author

I'm putting this into Stratis 1.1 preliminary review again as we may consider the problem of identifying the context of errors more urgent. We might want to consider a restricted goal, which does not attempt chaining, but does use failure crate to capture stack trace at point of error.

If we did that, we could perhaps start by sticking in failure errors only at leaf errors, i.e., locations where the error is picked up from an external crate.

@mulkieran
Copy link
Member Author

There is another possibility worth exploring. Perhaps we can simply make our existing error types implement Fail and then we can get the backtrace sort of for free.

@mulkieran
Copy link
Member Author

I'm taking this off in-progress, because it is now one of several alternatives that I'm exploring.

@mulkieran mulkieran removed this from In Progress in Stratis 1.1 Dec 3, 2018
@mulkieran
Copy link
Member Author

rebased. Keeping around for reference only.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

Superceded by #1499. We can always take a look at this as a reference if need to, but might as well close at this time.

@mulkieran mulkieran closed this Oct 9, 2019
@mulkieran mulkieran deleted the master-failure branch October 9, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants