-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wallet history receive sub-query #644
Conversation
Normal wallet testing passed:
|
Tested Smart Contract execution:
|
See output below from calling
|
We shouldn't need type 4 as it is legacy behaviour for the
I assume the wallet UI would have been showing "create" / "call" for these SC transactions. |
src/Stratis.Features.SQLiteWalletRepository/Tables/HDTransactionData.cs
Outdated
Show resolved
Hide resolved
I have now tested all the scenarios and they work. STRAX is unaffected. |
* Fix history receive sub-query * Fix formatting * Refactor * Fix null handling * Add Type 4 * CreateOrCall code updates * Only non-coinbase rows for Cirrus * Fix Group By * Fix Group By * Add SUM on non-groupby `Value` field * Revert Group By fixes for now * Undo AddressType change * Undo SUM * Undo change * Undo change * Undo change * Undo changes * Fix formatting * Fix Cirrus network detection
https://app.clickup.com/t/4f10mb