Bug fixes for and extensions of new Java API #542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 7, 2014 11:20
TODO: Special exec strategy (runtime + optimizer) based on hash join required.
Either no duplicates of filtering side in HT or filtered tuples removed from HT after first match.
Closed
| } | ||
|
|
||
| @Override | ||
| protected BinaryNodeTranslation translateToDataFlow() { | ||
| // TODO: Runtime support required. Each left tuple may be returned only once. | ||
| // Special exec strategy (runtime + optimizer) based on hash join required. | ||
| // Either no duplicates of right side in HT or left tuples removed from HT after first match. |
There was a problem hiding this comment.
Can't you implement that using CoGroup?
There was a problem hiding this comment.
I think it is almost easier to do this with an extra runtime op. Those are
line 20 lines only as well...
Am 07.03.2014 20:58 schrieb "Robert Metzger" notifications@github.com:
In
stratosphere-java/src/main/java/eu/stratosphere/api/java/operators/JoinOperator.java:} @Override protected BinaryNodeTranslation translateToDataFlow() {
// TODO: Runtime support required. Each left tuple may be returned only once.// Special exec strategy (runtime + optimizer) based on hash join required.// Either no duplicates of right side in HT or left tuples removed from HT after first match.Can't you implement that using CoGroup?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/542/files#r10397365
.
|
Fixes #543 |
|
Rebased to stratosphere:staging branch in #565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TupleComparator(normalized key writing) @StephanEwen please verifyBasicTypeComparator(inverted sort order) @StephanEwen please verifyTypeExtractorandTupleTypeInfoto work with subclasses of Tuple classes.