Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in MapNode #544

Closed
wants to merge 1 commit into from
Closed

Fix bug in MapNode #544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions stratosphere-compiler/src/main/java/eu/stratosphere/compiler/dag/MapNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public MapNode(PlainMapOperatorBase<?> pactContract) {
}

@Override
public MapOperatorBase<?> getPactContract() {
return (MapOperatorBase<?>) super.getPactContract();
public PlainMapOperatorBase<?> getPactContract() {
return (PlainMapOperatorBase<?>) super.getPactContract();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong, but won't this break with the Record API where Map extends MapOperatorBase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I meant by historic reasons. We could change FlatMap and call the method there map() as well...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fix removed the method as it was done before the merge and the build passed Travis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as well, because MapOperatorBase is converted to a CollectorMapNode, not this MapNode here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this needs urgent cleanout. I'll try and look over the PRs
soon...

}

@Override
Expand Down