Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added description and comments on analysis_direction parameter #491

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

Fixes Issue #487

Changes proposed

I have updated the "usage.md" file to include a description of the analysis_direction parameter.
I have also updated the "config_parser.py" file to add a short comment on the usage of the parameter

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash changed the base branch from master to develop March 23, 2024 14:50
@AlyaGomaa
Copy link
Collaborator

hello @Sekhar-Kumar-Dash Thank you for the PR
The docs for this parameter in the config/slips.conf file are a bit outdated too, would it be possible to update them to before merging your PR?

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 25, 2024

hello @Sekhar-Kumar-Dash Thank you for the PR The docs for this parameter in the config/slips.conf file are a bit outdated too, would it be possible to update them to before merging your PR?

hey @AlyaGomaa thank you for reviewing my pull request. Certainly, I will update this documentation as well

@Sekhar-Kumar-Dash
Copy link
Contributor Author

@AlyaGomaa I made the required changes please take a look.
Thank you

@AlyaGomaa AlyaGomaa merged commit eca90c9 into stratosphereips:develop Mar 25, 2024
1 check passed
@AlyaGomaa
Copy link
Collaborator

Perfect. Thanks for your contribution!

@Sekhar-Kumar-Dash
Copy link
Contributor Author

Sekhar-Kumar-Dash commented Mar 25, 2024

Perfect. Thanks for your contribution!

@AlyaGomaa you are welcome.It feels real great to have my first PR merged to your repo.Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants