Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more tests to test_horizontal_portscans.py #507

Merged
merged 21 commits into from
Apr 5, 2024

Conversation

Sekhar-Kumar-Dash
Copy link
Contributor

@Sekhar-Kumar-Dash Sekhar-Kumar-Dash commented Apr 2, 2024

Fixes Issue #511

Changes proposed

With this pull request, I have added more tests to test_horizontal_portscans.py, which will improve the code coverage

Check List

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Sekhar-Kumar-Dash and others added 20 commits April 2, 2024 20:26
…whitelists_evidence_from_interface

Fix whitelists evidence from interface and whitelist alerts to all orgs by default
…the-new-slips-threshold

Change the default slips evidence detection threshold
@AlyaGomaa
Copy link
Collaborator

Hello @Sekhar-Kumar-Dash Very nice work you've done there, thank you!
Once the checks pass i will merge it.

However i have one small comment, i saw many duplicate functions in your PR, i recommend you check those before your future PRs
Usually i don't check them manually, they are displayed as warnings in IDEs like pycharm so you can check that before committing, and i believe we have it as a pre-commit hook so in the future commits will be automatically rejected until that's fixed.

Thanks for the hard work! Keep it up.

@AlyaGomaa AlyaGomaa merged commit 4f2521b into stratosphereips:develop Apr 5, 2024
1 check passed
@Sekhar-Kumar-Dash
Copy link
Contributor Author

Hi @AlyaGomaa Thank you so much for reviewing my PR and for making the corrections. Sorry for the duplicate functions, I will check that out

@AlyaGomaa
Copy link
Collaborator

You're welcome!:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants