Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design - [Text based] Configure Lens suggestion on the fly from Discover #26

Conversation

andreadelrio
Copy link

@andreadelrio andreadelrio commented Jun 30, 2023

Summary

This PR:

  • Removes the menuRight icon in the flyout (it was causing empty space on the left side of the flyout which looked off). Instead, we should use a footer with the Close button. Doing this will also align us better with the Lens flyout in Dashboard (which will also have a footer).
  • Reduces the size of the callout
  • Adds some margin around the histogram for better display of charts (esp. the waffle one)
  • Gives the flyout the same gray background as the rest of Discover (again to be better aligned with the upcoming Dashboard flyout)

Result:

image

Before

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@stratoula stratoula merged commit 0e81095 into stratoula:textbased-configurable-flyout Jul 3, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants