Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace future_job with min_ntime in mining job messages #335

Closed
6 tasks
Tracked by #319
rrybarczyk opened this issue Nov 1, 2022 · 1 comment
Closed
6 tasks
Tracked by #319

Replace future_job with min_ntime in mining job messages #335

rrybarczyk opened this issue Nov 1, 2022 · 1 comment
Assignees
@Fi3 @rrybarczyk
Labels
good first issue Good for newcomers spec incompatibility Issues ensuring SRI follows the specs
Milestone
MVP 2

Comments

@rrybarczyk
Copy link
Collaborator

rrybarczyk commented Nov 1, 2022 •
edited

There has been a spec change that removes the future_job field from the mining job messages and replaces it with min_ntime. The affected files are:

  • protocols/v2/roles-logic-sv2
  • protocols/v2/subprotocols/mining
  • protocols/v2/subprotocols/template-distribution
  • Pool: roles/v2/pool
  • SV2 MD: roles/v2/test-utils/mining-device
  • SV1/SV2 Translator proxy: roles/translator
@rrybarczyk rrybarczyk self-assigned this Nov 1, 2022
@rrybarczyk rrybarczyk mentioned this issue Nov 1, 2022
Closed
9 tasks
@pavlenex pavlenex mentioned this issue Nov 23, 2022
Closed
@Fi3 Fi3 self-assigned this Nov 23, 2022
@pavlenex pavlenex added the spec incompatibility Issues ensuring SRI follows the specs label Dec 5, 2022
@pavlenex pavlenex added the good first issue Good for newcomers label Jan 7, 2023
@pavlenex pavlenex added this to the MVP 2 milestone Jan 12, 2023
@pavlenex
Copy link
Collaborator

pavlenex commented Apr 6, 2023

This has been done in #503

@pavlenex pavlenex closed this as completed Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fi3 Fi3

@rrybarczyk rrybarczyk

Labels
good first issue Good for newcomers spec incompatibility Issues ensuring SRI follows the specs
Projects
SV2 Roadmap 🛣️
Archived in project
Milestone
MVP 2
Development

No branches or pull requests
3 participants
@Fi3 @rrybarczyk @pavlenex