Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NewTemplate.merkle_path in bitcoind #567

Closed
Fi3 opened this issue May 12, 2023 · 3 comments
Closed

Fix NewTemplate.merkle_path in bitcoind #567

Fi3 opened this issue May 12, 2023 · 3 comments
Assignees
Milestone

Comments

@Fi3
Copy link
Collaborator

Fi3 commented May 12, 2023

NewTemplate.merkle_path should be the smaller path possible needed to calculate the merkle root given the coinbase tx. Right now is composed by all the tx ids of the txs that are in the candidate block.

priority 6/10

@pavlenex pavlenex added this to the MVP3 milestone May 16, 2023
@pavlenex
Copy link
Collaborator

@Fi3 I think we fixed this one?

@Sjors
Copy link
Collaborator

Sjors commented Jan 15, 2024

I think that's why the helper function GetMerklePathForCoinbase(const CBlock& block) was added to bitcoin/bitcoin#28983

If that's correct then this issue can be closed. It needs some refactoring, but that doesn't have to be tracked here.

@Fi3
Copy link
Collaborator Author

Fi3 commented Jan 15, 2024

yep is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants