Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace JN graphics with JD #184

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

pavlenex
Copy link
Collaborator

@pavlenex pavlenex commented Oct 2, 2023

This PR replaces the outdated JN graphics.

One thing remaining here is how to handle the config D. IMO Config D should be the one displayed prominently in the tabs, so config D should be in front of config A at least until we have fw. Thoughts?

This PR replaces the outdated JN graphics. One thing remaining here is how to handle the config D. IMO Config D should be the one displayed prominently in the tabs, so config D should be in front of config A at least until we have fw. Thoughts?
@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for startling-capybara-2231ea ready!

Name Link
🔨 Latest commit 46ef094
🔍 Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/651af4684066c900073d80e3
😎 Deploy Preview https://deploy-preview-184--startling-capybara-2231ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GitGab19
Copy link
Collaborator

GitGab19 commented Oct 3, 2023

This PR replaces the outdated JN graphics.

One thing remaining here is how to handle the config D. IMO Config D should be the one displayed prominently in the tabs, so config D should be in front of config A at least until we have fw. Thoughts?

I agree with you.
I think we could also simply renaming configs since they're just mentioned into the getting-started guide which will be updated in the next days.
Also because it sounds strange to have a first look at the guide and start with Config C/D, instead of A/B

@pavlenex
Copy link
Collaborator Author

pavlenex commented Oct 6, 2023

I will merge this one and do a follow up PR as I may want to modify text slightly.

@pavlenex pavlenex merged commit beba23b into stratum-mining:main Oct 6, 2023
4 of 5 checks passed
@pavlenex pavlenex mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants