Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started update milestone 3 #191

Merged

Conversation

pavlenex
Copy link
Collaborator

@pavlenex pavlenex commented Jan 26, 2024

Alternative to #190
Closes #186

@pavlenex pavlenex added this to the MVP3 Launch milestone Jan 26, 2024
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for startling-capybara-2231ea ready!

Name Link
🔨 Latest commit f7a1ab5
🔍 Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/65b7a1ff807f810008feeb5f
😎 Deploy Preview https://deploy-preview-191--startling-capybara-2231ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavlenex pavlenex requested a review from Fi3 January 26, 2024 18:16
@pavlenex
Copy link
Collaborator Author

Linkcheck is false (twitter firewall blocks the checker)

@plebhash @GitGab19 feel free to take a look when you get a chance. I am not sold on sidebar naming.structure but I guess we can rename those easily, structure-wise I am happy how things are nested.

src/getting-started.md Outdated Show resolved Hide resolved
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
pavlenex and others added 2 commits January 26, 2024 19:54
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
@plebhash
Copy link
Contributor

added a few suggestions

aside from them, LGTM

@plebhash
Copy link
Contributor

CI seems broken though

Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
@pavlenex
Copy link
Collaborator Author

Thanks for a thorough review and catching inconsistencies @plebhash! CI are triggered by false linkcheck since Twitter blocks it, as mentioned here good on that end, it's never reliable.

@pavlenex
Copy link
Collaborator Author

One thing missing in Google Doc and existing on a current guide is how to run a CPU miner. While we certainyl don't want to prioritize it, perhaps I could add it under "customization" or anywhere else. Up to you guys @plebhash @GitGab19

@plebhash

This comment was marked as outdated.

src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions to clarify better, a typo and other little things


### 1. Start **SV2 Pool**
- Community-hosted roles used: SV2 Pool, testnet Template Provider, and Job Declarator Server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use SV2 or Sv2 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think on the website we use SV2, so that's why, did we have a discussion around this, what's a preferred way?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think on the website we use SV2, so that's why, did we have a discussion around this, what's a preferred way?

It seems to me that we are mixing it also on website.
In docs we use Sv2 and Sv1, everywhere else is SV2 and SV1.
I don't have an opinion on this, the important thing is to have it in a uniformed way imo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should file a separate issue for it and fix it once there's consensus, Sv2 sounds good to me, but wouldn't block the progress of this PR over the linguistic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should file a separate issue for it and fix it once there's consensus, Sv2 sounds good to me, but wouldn't block the progress of this PR over the linguistic.

I agree with you.
Let's merge it 👍

src/getting-started.md Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
src/getting-started.md Outdated Show resolved Hide resolved
Co-Authored-By: Gabriele Vernetti <62447440+GitGab19@users.noreply.github.com>
@pavlenex pavlenex merged commit 5f7387c into stratum-mining:main Jan 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update getting-started page
3 participants