-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started update milestone 3 #191
Getting started update milestone 3 #191
Conversation
✅ Deploy Preview for startling-capybara-2231ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
added a few suggestions aside from them, LGTM |
CI seems broken though |
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: plebhash <147345153+plebhash@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some suggestions to clarify better, a typo and other little things
|
||
### 1. Start **SV2 Pool** | ||
- Community-hosted roles used: SV2 Pool, testnet Template Provider, and Job Declarator Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use SV2
or Sv2
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think on the website we use SV2, so that's why, did we have a discussion around this, what's a preferred way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think on the website we use SV2, so that's why, did we have a discussion around this, what's a preferred way?
It seems to me that we are mixing it also on website.
In docs we use Sv2
and Sv1
, everywhere else is SV2
and SV1
.
I don't have an opinion on this, the important thing is to have it in a uniformed way imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should file a separate issue for it and fix it once there's consensus, Sv2 sounds good to me, but wouldn't block the progress of this PR over the linguistic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should file a separate issue for it and fix it once there's consensus, Sv2 sounds good to me, but wouldn't block the progress of this PR over the linguistic.
I agree with you.
Let's merge it 👍
Co-Authored-By: Gabriele Vernetti <62447440+GitGab19@users.noreply.github.com>
Alternative to #190
Closes #186