Ntime for jobs #12
Merged
Ntime for jobs #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtrnka
force-pushed
the
ntime-for-jobs
branch
3 times, most recently
from
d27e410
to
c8f197f
Compare
jakubtrnka
force-pushed
the
ntime-for-jobs
branch
from
c8f197f
to
2fbdc50
Compare
rrybarczyk
reviewed
Oct 22, 2022
04-Mining-Protocol.md
Outdated
| +----------------+---------------+-------------------------------------------------------------------------------------+ | ||
| | job_id | U32 | Identifier of the job as provided by NewMiningJob or NewExtendedMiningJob message | | ||
| +----------------+---------------+-------------------------------------------------------------------------------------+ | ||
| | starting_ntime | OPTION[u32] | Empty if the job is intended for a future SetNewPrevHash message sent on this | |
There was a problem hiding this comment.
I prefer the name min_ntime, but if you don't like that for any reason, starting_ntime is also fine
There was a problem hiding this comment.
This was @TheBlueMatt suggestion. I don't have strong opinion on that.
There was a problem hiding this comment.
I thought the discord discussion ended up with min, I could be wrong.
There was a problem hiding this comment.
Too many communication channels, because I don't remember talking about this on discord. But whatever, let's keep the the original min_ntime.
|
Btw I took the liberty and removed the confusing label |
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.