Add max coinbase out sigops to CoinbaseOutputDataSize in TP protocol #86
Conversation
The template provide need a way to know how many sigops the pool want to include in the coinbase outupts, otherwise is not able to create a template that if mined will result in a valid block.
|
I can implement this on the template provider side. Let's recommend 400 as the default, as that's what Bitcoin Core has been using for ages ( This will need some coordination in deployment, especially if we don't change the protocol version number (see #82). |
|
@Sjors I addressed your comments. When we have consensus on this I can implement it in SRI and you can add it to TP. I think the most contentious point here is how to handle versioning |
|
I'll let you know here once I have a branch with this change in it for the Template Provider. If you can open a pull request on the SRI repo with the same change, we can test if they're compatible. |
This is still missing. Perhaps worded as:
|
not sure if we should recommend a default at all. If so I would go with 0. |
|
0 will create an invalid block if you your coinbase output is non-taproot. And you won't find out until someone starts spamming the mempool with bare multisig: https://bitcoinexplainedpodcast.com/@nado/episodes/bitcoin-explained-76-stamps-and-the-invalid-block-caused-by-it The reason I suggest 400 is because that's what |
|
|
||
| | Field Name | Data Type | Description | | ||
| | ----------------------------------- | --------- | ----------------------------------------------------------------------------------------------- | | ||
| | coinbase_output_max_additional_size | U32 | The maximum additional serialized bytes which the pool will add in coinbase transaction outputs | | ||
| | coinbase_output_max_sigops | U16 | The maximum additional sigops which the pool will add in coinbase transaction outputs | |
There was a problem hiding this comment.
Should we add _additional for consistency?
what about: legacy pools should use 400, new pools should use 0 ? |
That assumes new pools want to use Taproot, that seems too DEMANDing :-) |
|
Here you go, completely untested: Sjors/bitcoin#45 (branch |
The template provide need a way to know how many sigops the pool want to include in the coinbase outupts, otherwise is not able to create a template that if mined will result in a valid block.