-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Stratum device config binary format #118
Conversation
- Merge profiles for stratum_bf and stratum_bfrt
Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the bfrt branch is still under active development, pinning the pipeline builder by checksum is probably not a bad idea. We can switch to a release-tagged version once we have a Stratum release with the builder in it.
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
============================================
+ Coverage 68.59% 69.70% +1.10%
Complexity 224 224
============================================
Files 17 17
Lines 1640 1614 -26
Branches 135 133 -2
============================================
Hits 1125 1125
+ Misses 440 414 -26
Partials 75 75
Continue to review full report at Codecov.
|
* Use Stratum device config binary format * Simplify the pipeconf - Merge profiles for stratum_bf and stratum_bfrt * remove device parameter from ptf_runner * fix tests * Apply suggestions from code review Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org> * Minor cleanup to build.sh * add pipeline config build image sha * remove stratum_bf from pipeconf name Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
* Use Stratum device config binary format * Simplify the pipeconf - Merge profiles for stratum_bf and stratum_bfrt * remove device parameter from ptf_runner * fix tests * Apply suggestions from code review Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org> * Minor cleanup to build.sh * add pipeline config build image sha * remove stratum_bf from pipeconf name Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
* Use Stratum device config binary format * Simplify the pipeconf - Merge profiles for stratum_bf and stratum_bfrt * remove device parameter from ptf_runner * fix tests * Apply suggestions from code review Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org> * Minor cleanup to build.sh * add pipeline config build image sha * remove stratum_bf from pipeconf name Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
* Use Stratum device config binary format * Simplify the pipeconf - Merge profiles for stratum_bf and stratum_bfrt * remove device parameter from ptf_runner * fix tests * Apply suggestions from code review Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org> * Minor cleanup to build.sh * add pipeline config build image sha * remove stratum_bf from pipeconf name Co-authored-by: Carmelo Cascone <carmelo@opennetworking.org>
This pull request change the pipeline config format for all profiles and platforms
Parts modified:
TODO:
latest
version/tag of thestratum-bf-pipeline-builder
container image? (not harmful to just use the latest version with shasum for now)Closes #39