Stamp Stratum release binaries #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
force-pushed
the
version-in-logs
branch
from
c710ffa
to
2781ec4
Compare
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 78.01% 78.01%
=======================================
Files 333 333
Lines 29953 29953
=======================================
Hits 23369 23369
Misses 6584 6584 |
bocon13
reviewed
Jan 20, 2021
bocon13
reviewed
Jan 20, 2021
bocon13
reviewed
Jan 20, 2021
bocon13
reviewed
Jan 20, 2021
pudelkoM
commented
Jan 20, 2021
Yi-Tseng
reviewed
Jan 20, 2021
pudelkoM
commented
Jan 22, 2021
pudelkoM
commented
Jan 23, 2021
pudelkoM
commented
Jan 23, 2021
pudelkoM
force-pushed
the
version-in-logs
branch
from
25869ee
to
07800f3
Compare
pudelkoM
commented
Jan 23, 2021
pudelkoM
force-pushed
the
version-in-logs
branch
from
07800f3
to
b39ca4d
Compare
pudelkoM
force-pushed
the
version-in-logs
branch
from
b39ca4d
to
66094ef
Compare
pudelkoM
force-pushed
the
version-in-logs
branch
2 times, most recently
from
c3f3cab
to
e2f36e7
Compare
|
supersedes #500 |
pudelkoM
force-pushed
the
version-in-logs
branch
2 times, most recently
from
dbb709b
to
718c037
Compare
Print a INFO log message on startup with the stamping information like commit, user, build host and timestamp. Also sets the version for gflags --version.
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
pudelkoM
force-pushed
the
version-in-logs
branch
from
718c037
to
3e9a591
Compare
This reverts commit b4e7268.
pudelkoM
force-pushed
the
version-in-logs
branch
from
3e9a591
to
016c017
Compare
|
CI caching seems to be happy with the stamp config. I'll merge this change and monitor the situation over the next couple of PRs. |
pudelkoM
force-pushed
the
version-in-logs
branch
from
a3c1c60
to
7eb25d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a INFO log message on startup with the stamping information like commit, user, build host and timestamp. Also sets the version for gflags
--version.Stamping is only enabled for release builds, but disabled for tests to allow better caching.
This change automatically applies to all binaries calling
InitStratumLogging, which includes all of our tools as well.Examples
Known issues
Our CI process modifies the git tree by patching the bazel config. This means all published build artifacts will report
(Modified)in their version. Since having any version information right now is more valuable than 100% correct info, this is an acceptable tradeoff and can be addressed in a later issue.Closes #500