Use RE2 for yang mac-address parsing
#593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
force-pushed
the
yang-tree-cleanup
branch
from
e50a595
to
9b5a848
Compare
Codecov Report
@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 79.17% 79.17% -0.01%
==========================================
Files 339 339
Lines 30915 30909 -6
==========================================
- Hits 24477 24471 -6
Misses 6438 6438
|
Yi-Tseng
reviewed
Mar 26, 2021
pudelkoM
commented
Mar 26, 2021
bocon13
reviewed
Apr 6, 2021
bocon13
reviewed
Apr 6, 2021
pudelkoM
force-pushed
the
yang-tree-cleanup
branch
5 times, most recently
from
f0d0a1b
to
05bc3b7
Compare
pudelkoM
commented
Apr 6, 2021
pudelkoM
commented
Apr 7, 2021
| @@ -1343,7 +1339,7 @@ void SetUpInterfacesInterfaceEthernetConfigMacAddress(uint64 node_id, | |||
| return status; | |||
| } | |||
There was a problem hiding this comment.
This feels like RETURN_IF_ERROR, but check other places.
pudelkoM
force-pushed
the
yang-tree-cleanup
branch
3 times, most recently
from
7bf6f9b
to
91542d7
Compare
pudelkoM
force-pushed
the
yang-tree-cleanup
branch
from
399c8b3
to
53abae1
Compare
pudelkoM
changed the title
RE2 for yang mac-address parsing
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issues:
::google::protobuf::uint64->uint64<regex>-> RE2YangStringToMacAddresssaferThis PR also fixes things introduces in commit 6e71349.