Merge BfrtActionProfileManager into BfrtTableManager
#774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
commented
Jul 8, 2021
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 77.87% 78.01% +0.13%
==========================================
Files 334 333 -1
Lines 30008 29953 -55
==========================================
- Hits 23370 23369 -1
+ Misses 6638 6584 -54
|
pudelkoM
force-pushed
the
bfrt-merge-action-profile-manager
branch
from
b1d0347
to
2506a61
Compare
pudelkoM
commented
Jul 8, 2021
pudelkoM
force-pushed
the
bfrt-merge-action-profile-manager
branch
from
2506a61
to
a6c19f6
Compare
pudelkoM
force-pushed
the
bfrt-merge-action-profile-manager
branch
from
a6c19f6
to
01275ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The separation of
BfrtActionProfileManagerandBfrtTableManagerwas largely a logical one, not because of state or complexity concerns.P4Runtime one-shot action profile groups blur the lines between those two and would be hard to implement within the current structure. This change merges the two managers into one.