Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up version log message for unstamped builds #787

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Clean up version log message for unstamped builds #787

merged 3 commits into from
Jan 27, 2022

Conversation

bocon13
Copy link
Member

@bocon13 bocon13 commented Jul 16, 2021 •
edited 

I20210716 08:10:58.377281  8313 logging.cc:63] Stratum version 0 built at 1970-01-01T00:00:00+00:00 on host redacted by user redacted.

to

I20210716 08:11:33.487955  9215 logging.cc:72] Stratum version: not stamped.

With --stamp:

I20210716 08:12:07.322472  9929 logging.cc:64] Stratum version: 45f0d34168fe526e293550e82bd72fbf1daf67b5 built at 2021-07-16T08:12:05+00:00 on host 84bc90ff210e by user brian.

@bocon13 bocon13 requested a review from pudelkoM July 16, 2021 08:22
@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited

Codecov Report

Merging #787 (fc0ef9a) into main (3af60d6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         336      336           
  Lines       30397    30397           
=======================================
  Hits        23935    23935           
  Misses       6462     6462

@bocon13 bocon13 added this to the 2022-03 Release milestone Dec 14, 2021
@bocon13
Copy link
Member Author

bocon13 commented Dec 14, 2021

@pudelkoM any objections?

pudelkoM
pudelkoM approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@pudelkoM pudelkoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concerns. LGTM

(Not a fan of unnecessary conditionals, but this output is for humans anyway. [Until somebody starts parsing it])

@bocon13 bocon13 merged commit 9ac0172 into main Jan 27, 2022
@bocon13 bocon13 deleted the version-log branch January 27, 2022 20:40
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 14, 2024
@ffoulkes
Clean up version log message for unstamped builds (stratum#787)
3ae0f60 
Note: this overlaps (and may be a suitable substitute for) the
kTimestampEnabled flag that was introduced to support the cmake
build. We've combined the two for the time being.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes added a commit to ipdk-io/stratum-dev that referenced this pull request Jan 17, 2024
@ffoulkes
Clean up version log message for unstamped builds (stratum#787)
126695b 
Note: this overlaps (and may be a suitable substitute for) the
kTimestampEnabled flag that was introduced to support the cmake
build. We've combined the two for the time being.

Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pudelkoM pudelkoM pudelkoM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022-03 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bocon13 @pudelkoM