Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for BfrtNode #792

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Add unit tests for BfrtNode #792

merged 1 commit into from
Jul 23, 2021

Conversation

pudelkoM
Copy link
Member

@pudelkoM pudelkoM commented Jul 22, 2021

This PR adds unit tests for the BfrtNode and makes other Bfrt classes mock-able.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #792 (e9b5b02) into main (d1f1282) will increase coverage by 0.62%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   78.01%   78.63%   +0.62%     
==========================================
  Files         333      334       +1     
  Lines       29953    30004      +51     
==========================================
+ Hits        23368    23595     +227     
+ Misses       6585     6409     -176     
Impacted Files Coverage Δ
stratum/hal/lib/barefoot/bfrt_table_manager_mock.h 66.66% <66.66%> (ø)
...ratum/hal/lib/barefoot/bfrt_counter_manager_mock.h 75.00% <75.00%> (ø)
stratum/hal/lib/barefoot/bfrt_pre_manager_mock.h 75.00% <75.00%> (ø)
stratum/hal/lib/barefoot/bfrt_counter_manager.cc 33.33% <100.00%> (+3.17%) ⬆️
stratum/hal/lib/barefoot/bfrt_packetio_manager.cc 87.10% <100.00%> (+0.57%) ⬆️
...atum/hal/lib/barefoot/bfrt_packetio_manager_mock.h 100.00% <100.00%> (ø)
stratum/hal/lib/barefoot/bfrt_pre_manager.cc 83.08% <100.00%> (+0.17%) ⬆️
stratum/hal/lib/barefoot/bfrt_table_manager.cc 25.19% <100.00%> (+0.83%) ⬆️
... and 4 more

@pudelkoM pudelkoM force-pushed the bfrt-node-tests branch 4 times, most recently from 1a23cee to 1b9b615 Compare July 22, 2021 19:07
@pudelkoM pudelkoM marked this pull request as ready for review July 22, 2021 21:34
@pudelkoM pudelkoM changed the title Add unit tests for BfrtNode Add unit tests for BfrtNode Jul 22, 2021
@pudelkoM pudelkoM merged commit 70ea6fd into main Jul 23, 2021
@pudelkoM pudelkoM deleted the bfrt-node-tests branch July 23, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant