Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PI and BMv2 versions #799

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Update PI and BMv2 versions #799

merged 3 commits into from
Jul 30, 2021

Conversation

bocon13
Copy link
Member

@bocon13 bocon13 commented Jul 28, 2021

Add veth_setup.sh and veth_teardown.sh to build Docker image
Update BMv2 reference chassis config will all 9 ports

Add veth_setup.sh and veth_teardown.sh to build Docker image
Update BMv2 reference chassis config will all 9 ports
@bocon13 bocon13 changed the title Update PI and BMv2 version Update PI and BMv2 versions Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #799 (9c2f9a8) into main (0ab5db9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #799   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         334      334           
  Lines       30004    30004           
=======================================
  Hits        23595    23595           
  Misses       6409     6409           

@bocon13
Copy link
Member Author

bocon13 commented Jul 29, 2021

@ccascone @pudelkoM @Yi-Tseng any objections to bumping the versions on PI and BMv2?

Also, I noticed that the PI version imported by Bazel and the version that we install into the build container are a little out of sync.

@pudelkoM
Copy link
Member

pudelkoM commented Jul 30, 2021

@ccascone @pudelkoM @Yi-Tseng any objections to bumping the versions on PI and BMv2?

Also, I noticed that the PI version imported by Bazel and the version that we install into the build container are a little out of sync.

No concerns from my side. Last time we updated PI it broke a few assumptions clients (e.g. ONOS) made about bmv2. Byte strings if I remember correctly.

@ccascone
Copy link
Member

LGTM

@bocon13
Copy link
Member Author

bocon13 commented Jul 30, 2021

Looks like the diff is pretty small. There is a fix in both PI and BMv2 for meters, so that may be the only place that we could see anything different.

@bocon13 bocon13 merged commit f2da8f3 into main Jul 30, 2021
@bocon13 bocon13 deleted the bmv2-update branch July 30, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants