-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Stratum-bfrt QoS configurable with singleton port IDs #808
Conversation
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
==========================================
- Coverage 78.63% 78.60% -0.04%
==========================================
Files 334 334
Lines 30006 30019 +13
==========================================
Hits 23595 23595
- Misses 6411 6424 +13
|
a521515
to
8927ce3
Compare
8927ce3
to
36bb4b0
Compare
The latest commit is an experiment with adding a common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proto changes look good to me
The common tofino port message did not really save any code once I found a way to shorten the namespace for the port type case, so I reverted it back to direct embed, which makes the config itself easier to read and write. |
This PR add the option to use
SingletonPort
IDs instead of sdk ports in the QoS config for Tofino.TODO: