Move QoS singleton port lookup into BfChassisManager
#822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #822 +/- ##
==========================================
- Coverage 78.60% 78.59% -0.02%
==========================================
Files 334 334
Lines 30011 30039 +28
==========================================
+ Hits 23590 23608 +18
- Misses 6421 6431 +10
|
pudelkoM
force-pushed
the
bfrt-qos-singleton-ports
branch
2 times, most recently
from
9bc7a89
to
d97d16b
Compare
The sdk wrapper has no knowledge about singleton ports, thus can not look up the correct dev port for them. This change fixes a bug where the singleton port ID is confused with the front panel number, leading to dev port lookup errors and failing a ChassisConfig push.
pudelkoM
force-pushed
the
bfrt-qos-singleton-ports
branch
from
d97d16b
to
20f8250
Compare
pudelkoM
force-pushed
the
bfrt-qos-singleton-ports
branch
from
cd72be5
to
b4e2acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sdk wrapper has no knowledge about singleton ports, thus can not look up the correct dev port for them. This change fixes a bug where the singleton port ID is confused with the front panel number, leading to dev port lookup errors and failing a ChassisConfig push.