Fix Tofino port shaping cleanup on ChassisConfig push #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #824 +/- ##
=======================================
Coverage 78.59% 78.59%
=======================================
Files 334 334
Lines 30039 30042 +3
=======================================
+ Hits 23608 23611 +3
Misses 6431 6431
|
pudelkoM
force-pushed
the
bfrt-fix-port-shaping
branch
from
7fbd1a9
to
062a3bb
Compare
pudelkoM
force-pushed
the
bfrt-fix-port-shaping
branch
from
062a3bb
to
58e3c80
Compare
pudelkoM
changed the title
pudelkoM
changed the title
pudelkoM
changed the title
|
We (@dariusgrassi and I) confirmed that this change fixes the issue in a manual test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, pushing a new chassis config without any port shaping does not delete a previous config, i.e. shaping stays enabled.
This PR addresses this by always disabling port shaping first, then potentially applying the new config afterwards.
During a chassis config push, there will be a short period of time where the traffic rate could be higher than expected. Similar to how ports might flip up->down->up right now. Fixing this would require a more substantial rewrite of the
BfChassisManager.