Reject invalid MeterConfigs in Stratum-bfrt
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 78.56% 78.55% -0.01%
==========================================
Files 334 334
Lines 30057 30077 +20
==========================================
+ Hits 23613 23628 +15
- Misses 6444 6449 +5
|
pudelkoM
commented
Sep 20, 2021
pudelkoM
force-pushed
the
bfrt-validate-meter-config
branch
2 times, most recently
from
1d3ab72
to
6d74db9
Compare
pierventre
reviewed
Sep 21, 2021
bocon13
reviewed
Dec 8, 2021
pudelkoM
force-pushed
the
bfrt-validate-meter-config
branch
from
6d74db9
to
3fbc063
Compare
pierventre
approved these changes
Dec 9, 2021
bocon13
approved these changes
Dec 9, 2021
|
I'm totally ok with merging, one remaining thought was that the check should happen in p4_service to cover all backends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P4RT meters are trTCM according to RFC 2698.
Not all P4
MeterConfigs possible are actually valid. We don't want to solely rely on the SDE to reject those, therefore we introduce logic in Stratum to catch them early and with helpful error messages.