Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability by renaming variables in BfChassisManager #827

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

pudelkoM
Copy link
Member

config shadowed the ChassisConfig var. config_old was not very descriptive.

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #827 (a50f829) into main (a36276d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files         334      334           
  Lines       30039    30039           
=======================================
  Hits        23608    23608           
  Misses       6431     6431           
Impacted Files Coverage Δ
stratum/hal/lib/barefoot/bf_chassis_manager.cc 72.41% <100.00%> (ø)

@pudelkoM pudelkoM merged commit 9b23711 into main Sep 21, 2021
@pudelkoM pudelkoM deleted the shadowing-bf-chassis-manager branch September 21, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant