Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization needs to provide TLS key materials on startup #828

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Initialization needs to provide TLS key materials on startup #828

merged 2 commits into from
Oct 4, 2021

Conversation

eth0xFEED
Copy link
Member

@eth0xFEED eth0xFEED commented Sep 23, 2021 •
edited

resolves #829 hopefully 馃

@eth0xFEED eth0xFEED changed the title not clear why this is working NOT Merge, just to show tls code Sep 23, 2021
@eth0xFEED eth0xFEED mentioned this pull request Sep 23, 2021
Closed
@eth0xFEED eth0xFEED changed the title NOT Merge, just to show tls code Initialization needs to provide TLS key materials on startup Sep 23, 2021
@eth0xFEED eth0xFEED marked this pull request as ready for review September 23, 2021 17:29
@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited

Codecov Report

Merging #828 (94ef9a6) into main (3dbafcb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
- Coverage   78.59%   78.58%   -0.01%     
==========================================
  Files         334      334              
  Lines       30042    30046       +4     
==========================================
+ Hits        23611    23612       +1     
- Misses       6431     6434       +3
Impacted Files Coverage 螖
stratum/lib/security/credentials_manager.cc 5.95% <0.00%> (-0.30%) 猬囷笍
stratum/p4c_backends/fpm/parser_field_mapper.cc 92.02% <0.00%> (+0.26%) 猬嗭笍

pudelkoM
pudelkoM previously approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@pudelkoM pudelkoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just review this section of the style guide

@eth0xFEED
Copy link
Member Author

Thanks for the pointer @pudelkoM , will keep that in mind for future PRs !

@Yi-Tseng Yi-Tseng merged commit bbc254d into stratum:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yi-Tseng Yi-Tseng Yi-Tseng approved these changes

@pudelkoM pudelkoM pudelkoM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS server key_cert pair empty
3 participants
@eth0xFEED @Yi-Tseng @pudelkoM