Remove procmon checkin from Hal
#841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #841 +/- ##
==========================================
- Coverage 78.58% 78.57% -0.02%
==========================================
Files 334 334
Lines 30046 30019 -27
==========================================
- Hits 23611 23586 -25
+ Misses 6435 6433 -2
|
pudelkoM
force-pushed
the
remove-hal-procmon-checkin
branch
from
0a0f08c
to
3dad864
Compare
bocon13
reviewed
Oct 14, 2021
bocon13
reviewed
Oct 14, 2021
Procmon is not used anymore and the failed checkin causes unnecessary error log messages. The Procmon code itself is not removed by this change, just the checkin from `Hal`.
pudelkoM
force-pushed
the
remove-hal-procmon-checkin
branch
from
3dad864
to
448f250
Compare
pudelkoM
force-pushed
the
remove-hal-procmon-checkin
branch
from
448f250
to
f9ba8bb
Compare
bocon13
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Procmon is not used anymore and the failed checkin causes unnecessary error log messages. The Procmon code itself is not removed by this change, just the checkin from
Hal.Also cleans references to
cmal, another google-only service, which we never had.Progress towards #492