Add missing signal.h includes #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
reviewed
Nov 5, 2021
bocon13
force-pushed
the
bocon/signal-include
branch
from
6872bd4
to
47c1e9d
Compare
Codecov Report
@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 78.57% 78.57%
=======================================
Files 334 334
Lines 30019 30019
=======================================
+ Hits 23586 23587 +1
+ Misses 6433 6432 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for failing tests in #850
Not sure why compilation failures are happening now... possibly due to a dropped include in newer versions of gRPC
cc: @koconnor29