Only link against bfshell_plugin.so and enable pi for SDE 9.7.0 build
#859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #859 +/- ##
=======================================
Coverage 78.56% 78.56%
=======================================
Files 334 334
Lines 30057 30057
=======================================
Hits 23613 23613
Misses 6444 6444 |
|
Testing now with Stratum CI.... |
pudelkoM
previously approved these changes
Dec 8, 2021
Yes, you can find the error here: |
|
I also need to update the build flag for SDE 9.7.0 to include |
|
All build pass, should be good to go |
pudelkoM
changed the title
bfshell_plugin.so and enable pi for SDE 9.7.0 build
pudelkoM
approved these changes
Dec 8, 2021
bocon13
added a commit
that referenced
this pull request
Dec 10, 2021
- Partially revert #859 - Don't include PI in 9.7.0 build - Skip stratum_bf for SDE 9.7.0 in release script
bocon13
added a commit
that referenced
this pull request
Dec 10, 2021
- Partially revert #859 - Don't include PI in 9.7.0 build - Skip stratum_bf for SDE 9.7.0 in release script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"barefoot-bin/lib/bfshell_plugin*",can include some unexpected files when building with older version of SDEs which cause the build failed.