Replace stratum-dummy control cli with C++ implementation #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 78.81% 78.81%
=======================================
Files 336 336
Lines 30124 30124
=======================================
Hits 23742 23742
Misses 6382 6382 |
pudelkoM
force-pushed
the
dummy-cli-cpp
branch
from
abba11b
to
d000dc3
Compare
Yi-Tseng
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the dummy Python scripts controlling
stratum-dummywith a C++ native version. While the new version implements 100% of the functionality with the same user interface, the code this not as polished as it could be. This is acceptable due to the very low impact this CLI has.TODO: