Make file CLI flags and usage messages uniform #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
=======================================
Coverage 78.80% 78.80%
=======================================
Files 336 336
Lines 30128 30128
=======================================
Hits 23742 23742
Misses 6386 6386
|
pudelkoM
changed the title
Yi-Tseng
pushed a commit
that referenced
this pull request
Jan 9, 2022
The CLI flags related to TLS are ambiguous whether they expect a path to a file, or the actually file content. Established convention is using `<flag>_file` for files. This PR fixes this. It also removes the duplicate usage strings in both the docs and code, as they are auto-generated by gflags with the `--helpshort` flag. Some were already outdated and incorrect.
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 13, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI flags related to TLS are ambiguous whether they expect a path to a file, or the actually file content. Established convention is using
<flag>_filefor files. This PR fixes this.It also removes the duplicate usage strings in both the docs and code, as they are auto-generated by gflags with the
--helpshortflag. Some were already outdated and incorrect.