Enable -Werror=overloaded-virtual compiler flag
#896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 78.80% 78.79% -0.01%
==========================================
Files 336 336
Lines 30128 30130 +2
==========================================
Hits 23742 23742
- Misses 6386 6388 +2
|
This catches virtual functions that got overloaded by accident, e.g., different parameter types or constness.
pudelkoM
force-pushed
the
cc-flag-overloaded-virtual-func
branch
from
17cf5d5
to
f099d6e
Compare
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 13, 2024
- Flag was enabled by a previous merge. This commit updates a couple files that were evidently flagged when the flag was enabled. Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
- Flag was enabled by a previous merge. This commit updates a couple files that were evidently flagged when the flag was enabled. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches virtual functions that got overloaded by accident, e.g., different parameter types or constness.