Remove RETURN_ERROR macro
#901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
force-pushed
the
remove-return-error-macro
branch
3 times, most recently
from
ceae75e
to
819de89
Compare
Codecov Report
@@ Coverage Diff @@
## main #901 +/- ##
=======================================
Coverage 78.79% 78.80%
=======================================
Files 336 336
Lines 30130 30131 +1
=======================================
+ Hits 23742 23744 +2
+ Misses 6388 6387 -1
|
pudelkoM
force-pushed
the
remove-return-error-macro
branch
from
819de89
to
433f079
Compare
pudelkoM
force-pushed
the
remove-return-error-macro
branch
from
433f079
to
994c1bd
Compare
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 13, 2024
- Change applied independently several months ago. This commit is for ancillary changes made as part of the same PR. Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
- Change applied independently several months ago. This commit is for ancillary changes made as part of the same PR. Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of
RETURN_ERROR()withreturn MAKE_ERROR().RETURN_ERRORseems to be part of an older style of error handling that has not been present in the original Google code drop, other recent Google projects or Abseil. In Stratum, only contributed code reintroduced the macro into code. Replacement is automated and should not change any logic or program behavior.This change also brings us closer to the Abseil style: