-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CHECK_RETURN_IF_FALSE
with RET_CHECK
#902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pudelkoM
commented
Jan 14, 2022
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
January 14, 2022 01:27
e0d8011
to
bf9e9c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #902 +/- ##
==========================================
+ Coverage 79.10% 79.17% +0.07%
==========================================
Files 339 339
Lines 30938 30915 -23
==========================================
+ Hits 24474 24478 +4
+ Misses 6464 6437 -27
|
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
January 27, 2022 23:56
bf9e9c7
to
a051503
Compare
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
January 28, 2022 01:12
a051503
to
5e77e23
Compare
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
January 28, 2022 01:12
5e77e23
to
9d21185
Compare
Yi-Tseng
previously approved these changes
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
January 28, 2022 02:45
72d8248
to
7a2630a
Compare
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
commented
Jan 28, 2022
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
February 4, 2022 20:44
91e7903
to
fe6083f
Compare
pudelkoM
force-pushed
the
replace-check-return-if-false-macro
branch
from
February 4, 2022 21:58
fe6083f
to
47a694e
Compare
Lint failure is expected, as |
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 15, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
ffoulkes
added a commit
to ipdk-io/stratum-dev
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Derek G Foster <derek.foster@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the home-grown
CHECK_RETURN_IF_FALSE
macro with the more commonRET_CHECK
one. Semantics and behavior stay the same, no user-code changes needed. Code readability is improved a little, as the new macro is shorter, leading to less line splits.We hope that this will make migration to
absl::Status
easier eventually, as we will probably go with whatever solution Google comes up with.Fixes #579